Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow non-multiaddress api url #1296

Merged
merged 2 commits into from
Nov 11, 2019
Merged

fix: allow non-multiaddress api url #1296

merged 2 commits into from
Nov 11, 2019

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Nov 10, 2019 •
edited
Loading

Fixes the third issue mentioned here.

License: MIT
Signed-off-by: Henrique Dias hacdias@gmail.com

@hacdias
fix: allow non-multiaddress api url
df46f53 
License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
@hacdias hacdias requested a review from lidel November 10, 2019 20:24
@hacdias
feat: update ipfs-redux-bundle
ceed049 
License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
@hacdias
Copy link
Member Author

hacdias commented Nov 11, 2019

@lidel ready for review!

lidel
lidel approved these changes Nov 11, 2019
View reviewed changes
Copy link
Member

@lidel lidel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with proxy.js and works as expected 👌

@hacdias hacdias merged commit 490f68a into master Nov 11, 2019
@hacdias hacdias deleted the fix/url-api-addr branch November 11, 2019 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidel lidel lidel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hacdias @lidel