Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: build before e2e and run it on random port #1377

Merged
merged 14 commits into from
Jan 17, 2020
Merged

fix: build before e2e and run it on random port #1377

merged 14 commits into from
Jan 17, 2020

Conversation

lidel
Copy link
Member

@lidel lidel commented Jan 14, 2020 •
edited
Loading

Parent: #1164
Fixes required for ipfs/js-ipfs#2706

This PR:

  • ensures production version is present in build/ directory before e2e tests run on CI
  • http-server with webui from build/ starts on random port to avoid conflicts

@lidel lidel mentioned this pull request Jan 15, 2020
Merged
7 tasks
@lidel lidel merged commit 9feb41d into master Jan 17, 2020
@lidel lidel deleted the fix/test-external branch January 17, 2020 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lidel @hugomrdias