Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(i18n): sync, add ca and link to translation project #1499

Merged
merged 5 commits into from
May 28, 2020

Conversation

lidel
Copy link
Member

@lidel lidel commented May 27, 2020

This PR:

  • synchronizes translations
  • adds Catalan locale
  • adds link to IPFS Translation Project at Transifex to the LanguageModal
    • should improve the discoverability for people who want to add/improve translations

Comment on lines +31 to +34
<p className='lh-copy charcoal f6'>
{t('languageModal.translationProjectIntro')}<br/>
<a href="https://www.transifex.com/ipfs/public/" rel="noopener noreferrer" target="_blank" class="link blue">{t('languageModal.translationProjectLink')}</a>
</p>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to tweak style / text so it looks better 🙏 initial PoC looks like this:
2020-05-28--00-32-10

Copy link
Contributor

@jessicaschilling jessicaschilling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an awesome idea! 😊
Just a small text suggestion.
Also - do you mind making the language links blue, too?
Thank you!

public/locales/en/settings.json Outdated Show resolved Hide resolved
public/locales/en/settings.json Outdated Show resolved Hide resolved
lidel and others added 3 commits May 28, 2020 22:28
Co-authored-by: Jessica Schilling <jessica@protocol.ai>
Co-authored-by: Jessica Schilling <jessica@protocol.ai>
@lidel
Copy link
Member Author

lidel commented May 28, 2020

@jessicaschilling done, now looks like this:

Screenshot_2020-05-28 Settings - IPFS

Let me know if it is ok to merge.

FYSA I'd like to create a new webui release with recent fixes we all did (including this one) and try to ship it with go-ipfs 0.6 so more users can benefit from this 🙏

Copy link
Contributor

@jessicaschilling jessicaschilling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
The next time we touch this dialog, we should either center or right-justify the close button, but since I didn't think about it until now ... 😊

@lidel
Copy link
Member Author

lidel commented May 28, 2020

We also may need to reconsider style for links overall
(link blue turns teal-ish after link is visited)
but thats something for future PRs :-) merging!

@lidel lidel merged commit c69bd1d into master May 28, 2020
@lidel lidel deleted the feat/i18n-sync-ca branch May 28, 2020 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants