Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: uppercase & standardize repo stats display #1679

Merged
merged 1 commit into from
Oct 27, 2020

Conversation

jessicaschilling
Copy link
Contributor

@jessicaschilling jessicaschilling commented Oct 26, 2020

Closes #1677.

Improvements to the legends in the Files page repo stats box:

  • Uppercases to account for noun-capitalized languages (e.g. German)
  • Improves text contrast for better legibility
  • Uses link-blue text for consistency in link behavior
  • Changes font to Montserrat for visual consistency

Screenshot (Mac Chrome):
image

Note: In the longer term, would like to add hover underline for all links throughout UI, but that's a matter for a separate PR.

@jessicaschilling
Copy link
Contributor Author

@lidel and @rafaelramalho19 - mind a quick look? Thank you!

Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!
@rafaelramalho19 you may want to ensure those changes are also applied in epic/pinning-services branch 🙏 so we have no regression when its merged

Copy link
Contributor

@rafaelramalho19 rafaelramalho19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@jessicaschilling jessicaschilling merged commit 0314595 into master Oct 27, 2020
@jessicaschilling jessicaschilling deleted the fix/repo-stats-display branch October 27, 2020 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repo statistics are converted to lower case
3 participants