Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(tutor-mode): Added CLI subdirectories #1706

Merged
merged 1 commit into from
Jan 7, 2021
Merged

refactor(tutor-mode): Added CLI subdirectories #1706

merged 1 commit into from
Jan 7, 2021

Conversation

melegiul
Copy link
Contributor

@melegiul melegiul commented Jan 7, 2021 •
edited
Loading

Summary:

  • Reads modals root prop to insert current MFS path in CLI command of tutor mode
  • Applied for all import commands at file menu

Closes #1601

Screenshot:

mfs-subdirectory

@melegiul
refactor(tutor-mode): Added CLI subdirectories
6550617 
- Reads modals root prop to insert current MFS path in CLI command
- Applied for all import commands at file menu
- Fixes: ipfs#1601
@welcome

This comment has been minimized.

Sign in to view
@melegiul melegiul marked this pull request as ready for review January 7, 2021 11:41
@jessicaschilling
Copy link
Contributor

Built locally and did a quick functional review and LGTM 😊 but I want to defer to @lidel for a more thorough examination. @lidel, can you please take a look when you get a chance? Thank you!

jessicaschilling
jessicaschilling approved these changes Jan 7, 2021
View reviewed changes
Copy link
Contributor

@jessicaschilling jessicaschilling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for PRing this, @melegiul! LGTM but want to wait to merge until we get approval from @lidel.

@melegiul
Copy link
Contributor Author

melegiul commented Jan 7, 2021

Thank you @jessicaschilling for your review 😄 I will wait for the pending approval.

lidel
lidel approved these changes Jan 7, 2021
View reviewed changes
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really happy about attention to detail like that ❤️
Thank you @melegiul

@lidel lidel merged commit 6a22823 into ipfs:master Jan 7, 2021
@jessicaschilling
Copy link
Contributor

PS: @melegiul, any other contributions you'd like to make would be more than welcome! 😊

@melegiul
Copy link
Contributor Author

melegiul commented Jan 7, 2021

Thank you for your prompt feedback @lidel , @jessicaschilling I would be very happy to contribute another one soon 😄

@melegiul melegiul deleted the enhancement/cli-tutor-subdir branch April 18, 2021 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessicaschilling jessicaschilling jessicaschilling approved these changes

@lidel lidel lidel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLI tutor mode: Support subdirectories for "import" commands
3 participants
@melegiul @jessicaschilling @lidel