Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: trim input of "Import from IPFS" #1718

Merged
merged 1 commit into from
Feb 8, 2021
Merged

fix: trim input of "Import from IPFS" #1718

merged 1 commit into from
Feb 8, 2021

Conversation

FledgeXu
Copy link
Contributor

@FledgeXu FledgeXu commented Jan 30, 2021

Description

This PR adds a default trim to TextInputModal and it should improve kind of user experiences.
Like below:
before:
image

after:
image

@jessicaschilling
Copy link
Contributor

Thanks! We'll look in more detail on Monday. 😊

@jessicaschilling
Copy link
Contributor

(Edit - the team is deferred this week but this is on our radar for review as soon as possible!)

@lidel lidel changed the title Add trim to TextInputModal fix: trim input of "Import from IPFS" Feb 8, 2021
@lidel lidel merged commit 68549f4 into ipfs:master Feb 8, 2021
@ipfs ipfs deleted a comment from welcome bot Feb 8, 2021
lidel added a commit that referenced this pull request May 20, 2021
Closes #1775 my moving fix from #1718 to correct place
lidel added a commit that referenced this pull request May 21, 2021
Closes #1775 my moving fix from #1718 to correct place
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants