feat: remote pins on files page

[rafaelramalho19]

Closes #1502

[lidel]

Not sure if issues I had were caused by using different version of ipfs-http-client with connect-deps, but here is quick feedback:

• error handling seems to be missing. when I unpinned a file from one of services that are broken on purpose, I got this page crash

• assuming http-client issues caused below ones, but mentioning them for completeness:

  • I was not able to get cloud pin to show on Files screen
  • I have multiple services defined with Pinata endpoint, but I don't see them in "Set pinning" modal, I only see a single Pinata entry

@rafaelramalho19 we should be able to remove the need for connect-deps and use ipfs-http-client 49.x (it shipped with pin.remote), but may require fixes from #1655

[lidel]

We merged latest http-client with #1655 so connect-deps should no longer be necessary.

@rafaelramalho19 mind rebasing this PR?

[lidel]

I've merged fixes from main branch but there is some remaining work here:

• fix linter
• resolve conflicts
• rebase after Feat/pinning settings #1535 feat: remote pinning settings page #1713 is merged
• when I have multiple Pinata services the "Set pinning" modal shows "Pinata" only once (we need to merge feat: remote pinning settings page #1713 first and rebase)
• when one of services is offline entire Files screen crashes (screenshot)

[rafaelramalho19]

@lidel > when I have multiple Pinata services the "Set pinning" modal shows "Pinata" only once (we need to merge #1713 first and rebase)

This was actually never done apparently, ıt was so long ago I can't remember but I guess I didn't finish it, so I done it today 😄

I also replicated the colors from the settings page here

[rafaelramalho19]

when one of services is offline entire Files screen crashes

• What's the best way to reliably test this? Should I make an e2e test and try to reproduce this behavior there?
• It crashes when in dev mode right? If you "close the debugging modal" it should continue as normal right?

rebase after #1535 is merged

What do you mean by this? That PR was merged a long time ago 🤔

[lidel]

when one of services is offline entire Files screen crashes

This seems to be fixed in the latest version: the screen no longer crash.
Instead, when I pin a file to a service which is offline, no error is displayed and the file gets cloud pin badge, buf if I refresh the page the badge disappears.

What's the best way to reliably test this? Should I make an e2e test and try to reproduce this behavior there?

For dev just add a service with invalid endpoint or access token (so every request always fail).

I think the only way to do automatic tests is to add test/e2e/remote-pins.test.js with tests for adding/removing service and pinning files using invalid service and a valid one.

For valid one you can use js-mock-ipfs-pinning-service:

• runs in memory, so should be acceptable for CI
• you can force it to set status to 'pinned' by using CID with identity multihash like bafkqaaa (you can import it from IPFS via Files→Import→Import from IPFS → /ipfs/bafkqaaa)

That PR was merged a long time ago

My bad, meant #1713 :)