Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix download files feature #1789

Merged
merged 1 commit into from
May 19, 2021
Merged

fix: fix download files feature #1789

merged 1 commit into from
May 19, 2021

Conversation

hugomrdias
Copy link
Member

Abort download was being called right after starting to fetch data, because if useState receives a function that function is called to get the final value.
To fix the issue we just wrap the abort function with another function.

closes #1783

Abort download was being called right after starting to fetch data, because if useState receives a function that function is called to get the final value.
To fix the issue we just wrap the abort function with another function.

closes #1783
@hugomrdias hugomrdias self-assigned this May 19, 2021
@hugomrdias hugomrdias temporarily deployed to Deploy May 19, 2021 15:54 Inactive
@ipfs ipfs deleted a comment from welcome bot May 19, 2021
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
e2e for js-ipfs is unrelated – we track it in #1737

@lidel lidel merged commit 66cf28d into main May 19, 2021
@lidel lidel deleted the fix/1783 branch May 19, 2021 19:38
@Luflosi
Copy link
Contributor

Luflosi commented May 19, 2021

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to download files
3 participants