Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove ensureMFS call when generating share link #1801

Merged
merged 2 commits into from
Jun 11, 2021
Merged

remove ensureMFS call when generating share link #1801

merged 2 commits into from
Jun 11, 2021

Conversation

yusefnapora
Copy link
Contributor

This removes the call to ensureMFS in doFilesShareLink to fix and close #1744

I wasn't able to run the e2e tests on my machine, so we'll see if anything complains in CI, I guess :)

cc @lidel

@yusefnapora
Copy link
Contributor Author

I can get the e2e tests to pass locally against go-ipfs, but I get the same error as in CI for js-ipfs.

e2e tests with E2E_IPFSD_TYPE=go env PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=true PUPPETEER_EXECUTABLE_PATH=/Applications/Google\ Chrome.app/Contents/MacOS/Google\ Chrome E2E_IPFSD_TYPE=go npm run test:e2e

ipfs-webui@2.12.3 test:e2e
cross-env JEST_PUPPETEER_CONFIG=test/e2e/jest-puppeteer.config.js jest --verbose -c test/e2e/jest.config.js --runInBand

Determining test suites to run...
E2E using go-ipfs/0.8.0/ (/Users/yusef/work/repos/ipfs-webui/node_modules/go-ipfs/go-ipfs/ipfs) with Peer ID 12D3KooWPUDbhzrsfWeS1FkAHwBVLef6tQzckcfgAimdCGHGJLKy

(node:71386) [DEP0066] DeprecationWarning: OutgoingMessage.prototype._headers is deprecated
(Use node --trace-deprecation ... to show where the warning was created)
(node:71367) V8: /Users/yusef/work/repos/ipfs-webui/node_modules/borc/src/decoder.asm.js:3 Linking failure in asm.js: Unexpected stdlib member
(Use node --trace-warnings ... to show where the warning was created)
PASS test/e2e/peers.test.js (17.716 s)
Peers screen
✓ should have a clickable "Add connection" button (1184 ms)
✓ should confirm connection after "Add connection" (2498 ms)
✓ should have a peer from a "Local Network" (5112 ms)

PASS test/e2e/files.test.js (9.095 s)
Files screen
✓ should have the active Add menu (1596 ms)
✓ should allow for a successful import of two files (1796 ms)

PASS test/e2e/navigation.test.js (8.769 s)
Navigation menu
✓ should work for Status page (882 ms)
✓ should work for Files page (554 ms)
✓ should work for Explore page (1148 ms)
✓ should work for Peers page (337 ms)
✓ should work for Settings page (804 ms)

PASS test/e2e/settings.test.js (6.172 s)
Settings screen
✓ should show config of IPFS node (109 ms)

PASS test/e2e/explore.test.js (6.617 s)
Explore screen
✓ should have Project Apollo Archive as one of examples (112 ms)
✓ should open arbitrary CID (1385 ms)

PASS test/e2e/status.test.js (6.474 s)
Status page
✓ should have Status menu item (102 ms)
✓ should inform it is sucessfully connected to IPFS (25 ms)
✓ should display Peer ID of real IPFS node (30 ms)

(node:71367) V8: /Users/yusef/work/repos/ipfs-webui/node_modules/borc/src/decoder.asm.js:3 Linking failure in asm.js: Unexpected stdlib member
PASS test/e2e/remote-api.test.js (22.805 s)
API @ multiaddr
✓ should be possible to set via Settings page (4833 ms)
✓ should show full multiaddr on Status page (1530 ms)
✓ should show full multiaddr on Settings page (519 ms)
API @ URL
✓ should be possible to set via Settings page (884 ms)
✓ should show full multiaddr on Status page (624 ms)
✓ should show full multiaddr on Settings page (268 ms)
API with CORS and Basic Auth
✓ should work when localStorage[ipfsApi] is set to URL with inlined Basic Auth credentials (890 ms)
✓ should work when localStorage[ipfsApi] is set to a JSON string with a custom ipfs-http-client config (766 ms)
✓ should work when URL with inlined credentials are entered at the Settings page (1818 ms)
✓ should work when JSON with ipfs-http-client config is entered at the Settings page (2715 ms)

Test Suites: 7 passed, 7 total
Tests: 26 passed, 26 total
Snapshots: 0 total
Time: 77.796 s, estimated 113 s
Ran all test suites.

It looks like the e2e tests are failing against js-ipfs generally at the moment (#1737).

@ipfs ipfs deleted a comment from welcome bot Jun 11, 2021
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
Merging as e2e in js (#1737) needs to be tackled in separate pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Files -> Pins -> Share link crashes the app
2 participants