Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: link to pinning service docs if available #1810

Merged
merged 2 commits into from
Jul 5, 2021

Conversation

lidel
Copy link
Member

@lidel lidel commented Jun 24, 2021

This PR adds a link to docs next to "Secret access token", making it easier for users of predefined services like Pinata to learn how to generate a new token.

The link to docs is defined in

visitServiceUrl: 'https://pinata.cloud/documentation#PinningServicesAPI'

2021-06-24--23-52-20

This displays a link to pinning service docs next to "Secret access
token", making it easier for users of predefined services to learn how
to generate a new token in service UI.
@lidel lidel requested a review from momack2 June 24, 2021 21:58
@lidel lidel temporarily deployed to Deploy June 24, 2021 22:01 Inactive
Copy link
Contributor

@momack2 momack2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - would just remove the "?"

@lidel lidel temporarily deployed to Deploy June 24, 2021 22:48 Inactive
Co-authored-by: MollyM <momack2@users.noreply.github.com>
@lidel lidel merged commit 5314e47 into main Jul 5, 2021
@lidel lidel deleted the feat/pinning-service-docs-link branch July 5, 2021 11:52
@lidel lidel temporarily deployed to Deploy July 5, 2021 11:55 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants