Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dir sizes in big dirs #1815

Merged
merged 1 commit into from
Jul 5, 2021
Merged

fix: dir sizes in big dirs #1815

merged 1 commit into from
Jul 5, 2021

Conversation

lidel
Copy link
Member

@lidel lidel commented Jul 5, 2021 •
edited
Loading

This fixes dir size calculation when there was more than 100 items in a dir:

  • we now skip size fetching only when there is more than 1000 dirs
  • size calculation is performed only once and memoized per CID, reducing the number of sent htt requests

Closes #1805
Closes #1687

@lidel lidel temporarily deployed to Deploy July 5, 2021 12:27 Inactive
@lidel lidel merged commit ba36074 into main Jul 5, 2021
@lidel lidel deleted the fix/dir-sizes-in-big-dirs branch July 5, 2021 12:31
@xaiksan1 xaiksan1 mentioned this pull request Jun 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Size of a folder with many subfolders is not displayed Files: show CumulativeSize for directories
1 participant
@lidel