Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: FilesExplorerForm icons for differing browser text sizes #1916

Merged
merged 1 commit into from
Apr 4, 2022

Conversation

jayschwa
Copy link
Contributor

@jayschwa jayschwa commented Mar 23, 2022

I run my browser with a non-standard text size and I noticed that the FilesExplorerForm icons do not look correct. This changes the icon heights to relative units from the absolute (default) pixels.

Very small and very large text sizes before this change:

very_small_broken
very_large_broken

After:

very_small_fixed
very_large_fixed

I am using the Dark Reader extension for the dark theme. It is not part of this PR.

@welcome
Copy link

welcome bot commented Mar 23, 2022

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I guess there is no harm in merging this (fwiw I see no regression with default font size)

@lidel lidel merged commit e77afcb into ipfs:main Apr 4, 2022
@jayschwa jayschwa deleted the fix-files-explorer-form-icons branch May 22, 2022 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants