ES6/7 refactor, Remove jQuery #195
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| export | ||
| default class Table extends React.Component { | ||
|
|
||
| static propTypes: { |
There was a problem hiding this comment.
this needs to be an = instead of : I think
dignifiedquire
added
status/in-progress
This was referenced Jan 13, 2016
Closed
luigiplr
changed the title
luigiplr
changed the title
| @@ -1,17 +1,14 @@ | |||
| import React from 'react' | |||
| import {render} from 'react-dom' | |||
| import Router, {hashHistory} from 'react-router' | |||
There was a problem hiding this comment.
Why did you change this import?
There was a problem hiding this comment.
Standard format screamed.
| </tbody> | ||
| </Table> | ||
| </Table > |
|
Getting close :) just 9 linting errors and one test not passing: https://circleci.com/gh/ipfs/webui/273 |
|
Looking good, just missing the test failure (you can run it locally with |
|
Also needs merge with latest master please :) |
luigiplr
force-pushed
the
feature/es6-7
branch
from
76f7c67 to
aedbf73
Compare
|
@luigiplr one last thing, can you squash your commits into one, and merge with latest master one more time. Then I can merge it |
|
@dignifiedquire Sure thing |
luigiplr
force-pushed
the
feature/es6-7
branch
2 times, most recently
from
9dc9c41 to
6ed95f6
Compare
luigiplr
force-pushed
the
feature/es6-7
branch
from
6ed95f6 to
bd5d2fd
Compare
luigiplr
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR will:
-Bring codebase up to ES6 spec while utilizing a few select ES7 features. #syntaxSugar
-Remove jQuery as a dep altogether