Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add playwright code coverage #2014

Merged
merged 15 commits into from
Sep 12, 2022
Merged

feat: add playwright code coverage #2014

merged 15 commits into from
Sep 12, 2022

Conversation

SgtPooki
Copy link
Member

Related to #1965 in order to see where the riskier dependency updates are

@SgtPooki SgtPooki mentioned this pull request Aug 25, 2022
Open
@SgtPooki SgtPooki temporarily deployed to Deploy August 25, 2022 22:49 Inactive
@SgtPooki SgtPooki requested review from hacdias and lidel August 25, 2022 22:51
@SgtPooki SgtPooki temporarily deployed to Deploy August 26, 2022 00:34 Inactive
@SgtPooki SgtPooki temporarily deployed to Deploy August 30, 2022 18:15 Inactive
@SgtPooki SgtPooki temporarily deployed to Deploy August 30, 2022 18:36 Inactive
hacdias
hacdias reviewed Sep 1, 2022
View reviewed changes
Copy link
Member

@hacdias hacdias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look fine, but I'm trying to understand how we can see the report. I took a look at the logs, but it doesn't say much:

image

@SgtPooki
Copy link
Member Author

SgtPooki commented Sep 1, 2022

The changes look fine, but I'm trying to understand how we can see the report. I took a look at the logs, but it doesn't say much:

image

For now, the reports are just going to be available manually, until we can integrate with codecov with https://github.com/codecov/codecov-action#usage.

It looks like js-test-and-releast.yml which is part of Unified CI JS uses codecov: https://github.com/search?q=org%3Aipfs+codecov%2Fcodecov-action&type=code

@SgtPooki
Copy link
Member Author

SgtPooki commented Sep 1, 2022

Created #2016 to track the next tasks

@SgtPooki SgtPooki mentioned this pull request Sep 7, 2022
Closed
@SgtPooki SgtPooki requested a review from a team as a code owner September 12, 2022 19:03
@SgtPooki SgtPooki temporarily deployed to Deploy September 12, 2022 19:07 Inactive
@SgtPooki SgtPooki temporarily deployed to Deploy September 12, 2022 19:59 Inactive
@SgtPooki SgtPooki temporarily deployed to Deploy September 12, 2022 20:13 Inactive
@SgtPooki SgtPooki temporarily deployed to Deploy September 12, 2022 20:32 Inactive
@SgtPooki SgtPooki temporarily deployed to Deploy September 12, 2022 20:48 Inactive
@SgtPooki
Copy link
Member Author

@hacdias @lidel partially solved #2016 by adding codecov action, and you can see that the stats posted correctly at https://app.codecov.io/gh/ipfs/ipfs-webui/pull/2014

Merging this PR

@SgtPooki SgtPooki merged commit 0ecc822 into main Sep 12, 2022
@SgtPooki SgtPooki deleted the playwright-code-coverage branch September 12, 2022 21:14
ipfs-gui-bot pushed a commit that referenced this pull request Sep 13, 2022
@semantic-release-bot
chore(release): 2.18.1 [skip ci]
b30ed14 
## [2.18.1](v2.18.0...v2.18.1) (2022-09-13)

 CID `bafybeiageaoxg6d7npaof6eyzqbwvbubyler7bq44hayik2hvqcggg7d2y`

 ---

### Bug Fixes

* show '0 B' instead of '-' for zero-length files ([#2018](#2018)) ([fda3bf5](fda3bf5))
* update webui.ipfs.io dnslink on manual release ([#2024](#2024)) ([0f1e1c2](0f1e1c2)), closes [#2021](#2021)

### Tests

* add playwright code coverage ([#2014](#2014)) ([0ecc822](0ecc822))

### Trivial Changes

* pull transifex translations ([#2019](#2019)) ([5e59065](5e59065))
* **readme:** correct IPFS Desktop release link ([b76c0db](b76c0db))
* remove unused dependencies ([#2015](#2015)) ([f007d78](f007d78))
@ipfs-gui-bot
Copy link
Collaborator

🎉 This PR is included in version 2.18.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hacdias hacdias hacdias left review comments

@lidel lidel Awaiting requested review from lidel

Assignees
No one assigned
Labels
released
Projects
No open projects
IPFS-GUI (PL EngRes)
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SgtPooki @ipfs-gui-bot @hacdias