Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: e2e/explore.test.js succeeds in offline mode #2109

Merged

Conversation

SgtPooki
Copy link
Member

@SgtPooki SgtPooki commented Mar 21, 2023

  • test(e2e-explore): add apollo block fixtures
  • test(e2e-explore): remove children fixtures
  • test(e2e-explore): add project apollo archive test
  • test(e2e-explore): use fixtures for XKCD archives

fixes #2108
fixes #2106

should unblock kubo CI failure: https://app.circleci.com/pipelines/github/ipfs/kubo/9385/workflows/dfd6c3bb-f2d0-4cb1-9b06-f7a21d528d42/jobs/101478

@SgtPooki SgtPooki requested a review from a team as a code owner March 21, 2023 18:02
@SgtPooki SgtPooki linked an issue Mar 21, 2023 that may be closed by this pull request
@SgtPooki SgtPooki self-assigned this Mar 21, 2023
@SgtPooki SgtPooki temporarily deployed to Deploy March 21, 2023 18:07 — with GitHub Actions Inactive
Copy link
Member Author

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self review

test/e2e/explore.test.js Outdated Show resolved Hide resolved
test/e2e/fixtures/generateFixtures.sh Outdated Show resolved Hide resolved
@SgtPooki SgtPooki temporarily deployed to Deploy March 21, 2023 18:20 — with GitHub Actions Inactive
@whizzzkid whizzzkid temporarily deployed to Deploy March 22, 2023 04:13 — with GitHub Actions Inactive
Copy link
Contributor

@whizzzkid whizzzkid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need this quick fix.

Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @SgtPooki!
lgtm, small suggestion inline below + see promise comment from @whizzzkid above

.gitattributes Outdated Show resolved Hide resolved
SgtPooki and others added 2 commits March 22, 2023 12:07
Co-authored-by: Marcin Rataj <lidel@lidel.org>
Co-authored-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>
@SgtPooki SgtPooki temporarily deployed to Deploy March 22, 2023 19:11 — with GitHub Actions Inactive
@SgtPooki SgtPooki merged commit a5e9ac6 into main Mar 22, 2023
@SgtPooki SgtPooki deleted the 2108-bug-new-e2e-tests-for-explore-page-are-failing-in-kubo-ci branch March 22, 2023 20:14
ipfs-gui-bot pushed a commit that referenced this pull request Apr 24, 2023
## [3.0.0](v2.22.0...v3.0.0) (2023-04-24)

 CID `bafybeic4gops3d3lyrisqku37uio33nvt6fqxvkxihrwlqsuvf76yln4fm`

 ---

### ⚠ BREAKING CHANGES

* migrate to ESM (#2092)

### Features

* ipfs-http-client -> kubo-rpc-client ([#2098](#2098)) ([5e53c79](5e53c79)), closes [#issuecomment-1426219633](https://github.com/ipfs/ipfs-webui/issues/issuecomment-1426219633) [/github.com//issues/2079#issuecomment-1426337490](https://github.com/ipfs//github.com/ipfs/ipfs-webui/issues/2079/issues/issuecomment-1426337490)
* migrate to ESM ([#2092](#2092)) ([58a737c](58a737c))

### Bug Fixes

* e2e/explore.test.js succeeds in offline mode ([#2109](#2109)) ([a5e9ac6](a5e9ac6))
* ko language falls back to ko-KR ([#2102](#2102)) ([3369800](3369800))
* semantic release custom notes import ([#2113](#2113)) ([2f9f306](2f9f306))

### Trivial Changes

* add NetworkTraffic.stories.js ([#2094](#2094)) ([7a3bf46](7a3bf46))
* pull new translations ([#2101](#2101)) ([cbabac3](cbabac3))
* pull new translations ([#2104](#2104)) ([4a691a2](4a691a2))
* Pull transifex translations ([#2088](#2088)) ([a5b8a1c](a5b8a1c))
* Pull transifex translations ([#2091](#2091)) ([d209863](d209863))
* Pull transifex translations ([#2099](#2099)) ([1cf2fe7](1cf2fe7))
* Pull transifex translations ([#2111](#2111)) ([57d9b63](57d9b63))
@ipfs-gui-bot
Copy link
Collaborator

🎉 This PR is included in version 3.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: new e2e tests for explore page are failing in kubo CI test: improve explore page tests
4 participants