fix: dont spam IPFS_INIT_FAILED events to countly #2133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SgtPooki
changed the title
SgtPooki
changed the title
whizzzkid
reviewed
Jun 30, 2023
ipfs-gui-bot
pushed a commit
that referenced
this pull request
Jul 3, 2023
## [4.0.2](v4.0.1...v4.0.2) (2023-07-03) CID `bafybeicyp7ssbnj3hdzehcibmapmpuc3atrsc4ch3q6acldfh4ojjdbcxe` --- ### Bug Fixes * dont spam IPFS_INIT_FAILED events to countly ([#2133](#2133)) ([b8cf74a](b8cf74a)) ### Trivial Changes * **deps:** bump actions/checkout from 3.5.2 to 3.5.3 ([#2128](#2128)) ([de5aaf4](de5aaf4)) * **deps:** bump actions/download-artifact from 2 to 3 ([#2129](#2129)) ([5427709](5427709)) * **deps:** bump actions/github-script from 3 to 6 ([#2127](#2127)) ([d31f25c](d31f25c)) * **deps:** bump actions/upload-artifact from 2 to 3 ([#2126](#2126)) ([4b45b5f](4b45b5f)) * **deps:** bump gozala/typescript-error-reporter-action ([#2130](#2130)) ([3ea7f59](3ea7f59)) * **deps:** bump stefanzweifel/git-auto-commit-action ([#2125](#2125)) ([d76d95c](d76d95c)) * **readme:** remove mentions of js-ipfs ([#2134](#2134)) ([a43dd23](a43dd23)) * Update .github/dependabot.yml [skip ci] ([bea5f67](bea5f67)) * Update .github/workflows/stale.yml [skip ci] ([c5eaecc](c5eaecc)) * Update .github/workflows/stale.yml [skip ci] ([1fe83ec](1fe83ec))
|
🎉 This PR is included in version 4.0.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP.
fixes #1831
Note: We can debounce these and send only 1 every 5 min or so, but we're in breach of our countly contract currently because IPFS_INIT_FAILED is currently sending 4.8MM of these events from IPFS Desktop and 2MM from IPFS Web UI.
We do not need this many events to know if things are failing. Knowing how many times IPFS_INIT_FAILED per app load will be a MUCH better metric for informing how successful the app is for our users.
This also means, when the app boots up, if the user changes the API endpoint, we won't send an additional IPFS_INIT_FAILED metric. If we want to get a metric for this, we'll have to do some logic around
IPFS_API_ADDRESS_UPDATED,IPFS_API_ADDRESS_PENDING_FIRST_CONNECTION, and then the result of eitherIPFS_CONNECT_SUCCEEDorIPFS_CONNECT_FAILEDdemo
2023-06-29.at.18.08.02.-.Gray.Bear.mp4