chore: disable countly analytics and hide unused UI #2216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minimal changes to hide analytics UI components and stop sending opt-out metrics to instance which no longer works. Close #2198
SgtPooki
approved these changes
Apr 8, 2024
src/bundles/analytics.js
Outdated
| showAnalyticsBanner: false, | ||
| optedOut: false, | ||
| optedOut: !DISABLE_ALL_ANALYTICS, // disable analytics by default for now, see https://github.com/ipfs/ipfs-webui/issues/2198 |
There was a problem hiding this comment.
Suggested change
| optedOut: !DISABLE_ALL_ANALYTICS, // disable analytics by default for now, see https://github.com/ipfs/ipfs-webui/issues/2198 | |
| optedOut: DISABLE_ALL_ANALYTICS, // disable analytics by default for now, see https://github.com/ipfs/ipfs-webui/issues/2198 |
There was a problem hiding this comment.
don't we want to set this opted out to true for now? if not, we should probably leave as false
There was a problem hiding this comment.
Good catch – my bad, I negated the wrong line. Fixed in 1e04f2e + updated tests to confirm we hide UI and do no tracking by default.
lidel
force-pushed
the
chore/disable-and-hide-countly-analtics
branch
from
6f36572
to
1e04f2e
Compare
ipfs-gui-bot
pushed a commit
that referenced
this pull request
Apr 8, 2024
## [4.2.1](v4.2.0...v4.2.1) (2024-04-08) CID `bafybeigggyffcf6yfhx5irtwzx3cgnk6n3dwylkvcpckzhqqrigsxowjwe` --- ### Bug Fixes * **peers:** add connection accepts valid multiaddrs ([#2199](#2199)) ([91ff2ca](91ff2ca)) * **pinning:** update scaleway logo and link ([#2194](#2194)) ([b8ac64f](b8ac64f)) ### Trivial Changes * **deps:** bump actions/cache from 3 to 4 ([#2196](#2196)) ([e131185](e131185)) * disable countly analytics and hide unused UI ([#2216](#2216)) ([d137048](d137048)), closes [#2198](#2198) [/github.com//pull/2216/files#r1556085374](https://github.com/ipfs//github.com/ipfs/ipfs-webui/pull/2216/files/issues/r1556085374) * missed renames (api→rpc, .io→.tech) ([51b2952](51b2952)) * optimize CI caching ([#2183](#2183)) ([b8a71d9](b8a71d9)) * package-lock.json update ([#2200](#2200)) ([5abc5d0](5abc5d0)) * remove estuary ([b560f5c](b560f5c)) * Update .github/dependabot.yml [skip ci] ([f847301](f847301)) * Update .github/workflows/stale.yml [skip ci] ([03c1c89](03c1c89))
|
🎉 This PR is included in version 4.2.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies minimal changes to Close #2198 but without waiting for ipfs-shipyard/ignite-metrics#133
It does not remove any code, and allows restoring analytics once we have time to do ipfs-shipyard/ignite-metrics#133.