feat: migrate box component to typescript #2370
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tesol2y090
changed the title
SgtPooki
suggested changes
May 14, 2025
Member
SgtPooki
left a comment
SgtPooki
left a comment
There was a problem hiding this comment.
thanks for this!! just a few minor changes requested
| <section | ||
| className={className} | ||
| style={{ background: '#fbfbfb', ...style }} | ||
| {...props} |
Member
There was a problem hiding this comment.
adding ...props here is probably the right thing to do that we weren't previously doing, but: are we receiving extra props that will change the display unexpectedly?
| import React from 'react' | ||
| import { withTranslation, Trans } from 'react-i18next' | ||
| import Box from '../box/Box.js' | ||
| import Box from '../box/Box' |
Member
There was a problem hiding this comment.
we should include the file extension on the import
Comment on lines
+4
to
+8
| interface BoxProps { | ||
| className?: string; | ||
| style?: React.CSSProperties; | ||
| children: ReactNode; | ||
| [key: string]: any; // For any additional props |
Member
There was a problem hiding this comment.
if available,
Suggested change
| interface BoxProps { | |
| className?: string; | |
| style?: React.CSSProperties; | |
| children: ReactNode; | |
| [key: string]: any; // For any additional props | |
| interface BoxProps extends ComponentProps<'section'> { | |
| className?: string; | |
| style?: React.CSSProperties; | |
| children: ReactNode; |
or use explicit types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate Box Component to TypeScript
Changes
Boxcomponent from JavaScript to TypeScriptRelated Issues