Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the API accessible from the default HTTPS port #602

Merged
merged 1 commit into from
Nov 12, 2017
Merged

Make the API accessible from the default HTTPS port #602

merged 1 commit into from
Nov 12, 2017

Conversation

tsudoko
Copy link
Contributor

@tsudoko tsudoko commented Oct 19, 2017 •
edited
Loading

Fixes an issue mentioned in a comment for #95:

There's also problems if you're trying to put HTTPS in front of the UI via nginx. It loads fine, but then the web-ui immediately tries to access it's own content via HTTP rather then HTTPS and is blocked.

daviddias
daviddias approved these changes Nov 12, 2017
View reviewed changes
Copy link
Member

@daviddias daviddias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @tsudoko :)

@daviddias daviddias merged commit 37885d6 into ipfs:master Nov 12, 2017
@tsudoko tsudoko deleted the api-https-port branch November 12, 2017 16:16
@Stebalien Stebalien mentioned this pull request Dec 15, 2017
Closed
ShadowRZ pushed a commit to ShadowRZ/ipfs-webui that referenced this pull request Feb 9, 2018
@tsudoko @ShadowRZ
feat: Make the API accessible from the default HTTPS port (ipfs#602)
40c483c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daviddias daviddias daviddias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsudoko @daviddias