Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] feat: add file status #718

Closed
wants to merge 1 commit into from
Closed

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Jul 9, 2018

localhost_3000_ 1

Adds the peers icons. {0, 1} is for red. {2 ... 5} for orange and > 5 for the green one.

Altough this seems to be slowing down a lot the app. And despite setting the number of providers to 5, some responses have 200 and more.

And I find it weird that there are more people holding a file that is a medical report of mine. Am I using the API wrongly?

@olizilla @lidel what do you think? Could you take a look, please?

TODO

  • Tests for the bundle

@hacdias hacdias added the revamp label Jul 9, 2018
@hacdias hacdias mentioned this pull request Jul 9, 2018
18 tasks
@hacdias hacdias modified the milestone: in prog Jul 9, 2018
@hacdias hacdias added the status/in-progress In progress label Jul 9, 2018
@hacdias hacdias self-assigned this Jul 9, 2018
@lidel
Copy link
Member

lidel commented Jul 10, 2018

And I find it weird that there are more people holding a file that is a medical report of mine.

Why would you do that 😱

Jokes aside, as drive-by comment: findprovs probably does not work as expected and needs to be fixed before this PR moves forward.

Try:

curl "http://127.0.0.1:5001/api/v0/dht/findprovs?arg=QmbWqxBEKC3P8tqsKc98xmWNzrzDtRLMiMPL8wBuTGsMnR&num-providers=2"

Also, I have one file in MFS and it initial page load still produces a strange amount of requests for info about /:

2018-07-09_16-58_1

@hacdias
Copy link
Member Author

hacdias commented Jul 10, 2018

@lidel yeahh! I had the info to get stale after 100 milliseconds. Don't ask me why. Already changed to one minute 😄

@hacdias hacdias force-pushed the feat/revamp/file-status branch 2 times, most recently from d838cae to 87cc9b1 Compare July 17, 2018 18:41
@hacdias
Copy link
Member Author

hacdias commented Jul 19, 2018

As far as I tested, using js-ipfs-api with go-ipfs and js-ipfs give different results, which I don't think it's supposed. It seems that dht.findprovs is not consistent across implementations.

@olizilla
Copy link
Member

What results did you get with js-ipfs via js-ipfs-api? last time I tried to use the dht.findprovs via js-ipfs directly i hit an this issue ipfs/js-ipfs#1322 that meant no results go returned...

@hacdias
Copy link
Member Author

hacdias commented Jul 19, 2018

Yes, it was it @olizilla

@0x-r4bbit
Copy link

I'm about to send a fix for this, but as mentioned in the discussion, the API change needs some clarification.

@hacdias hacdias force-pushed the feat/revamp/file-status branch from 8a55c50 to 85939e0 Compare July 20, 2018 13:24
@hacdias hacdias force-pushed the feat/revamp/file-status branch from 5b8d525 to 99bc49e Compare July 27, 2018 14:03
@hacdias hacdias force-pushed the feat/revamp/file-status branch from 99bc49e to f3a1564 Compare July 27, 2018 14:13
@hacdias
Copy link
Member Author

hacdias commented Jul 27, 2018

@PascalPrecht any idea of when your PR is going to be merged? 😄

@0x-r4bbit
Copy link

0x-r4bbit commented Jul 27, 2018 via email

@0x-r4bbit
Copy link

Quick update here, a fix has landed in latest master over at interface-ipfs-core

@hacdias
Copy link
Member Author

hacdias commented Aug 3, 2018

Thanks @PascalPrecht! Now we just need Go's version to be fixed so we can use it here 😄

@hacdias
Copy link
Member Author

hacdias commented Sep 23, 2018

I'm closing this now due to many conflicts and this feature was postponed for the next release after 2.0.

@hacdias hacdias closed this Sep 23, 2018
@hacdias hacdias deleted the feat/revamp/file-status branch September 23, 2018 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants