feat: IPFS Desktop settings #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
The injected code can be found here. |
olizilla
requested changes
Nov 12, 2018
olizilla
requested changes
Nov 13, 2018
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
hacdias
force-pushed
the
feat/desktop-settings
branch
from
1671ff9 to
25c6966
Compare
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
|
@olizilla working and with a storybook 😄 |
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
|
@olizilla let's merge this! Somehow it started passing 😄 I'm happy for it 😃 It would be rad if you released a new version so we can use it on IPFS Desktop right away! |
olizilla
reviewed
Nov 20, 2018
olizilla
reviewed
Nov 20, 2018
olizilla
requested changes
Nov 20, 2018
|
@hacdias please revert the change to the package-lock.json. We need to upgrade ipld and ipld-explorer-components together or we hit breaking changes that causes errors when trying to view some ipld types. |
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More info see: ipfs/ipfs-desktop#674.
IPFS Desktop injects a bundle on
window.ipfsDesktop. If it's present, we show IPFS Desktop specific settings.(Screenshot taken with IPFS Desktop)
License: MIT
Signed-off-by: Henrique Dias hacdias@gmail.com