Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add loading animation for files resp #949

Merged
merged 4 commits into from
Feb 6, 2019

Conversation

fsdiogo
Copy link
Contributor

@fsdiogo fsdiogo commented Feb 1, 2019

Adds a loading animation when changing folders because some requests can hang for a bit and there was no clear indication that something was going on.

When you click on a folder, the files list gets an opacity and I went for something like the youtube cards animation, but keeping the content visible:

anim

Fixes #926.

@fsdiogo fsdiogo self-assigned this Feb 1, 2019
@ghost ghost added the status/in-progress In progress label Feb 1, 2019
fsdiogo and others added 3 commits February 5, 2019 17:44
@ghost ghost assigned olizilla Feb 6, 2019
@fsdiogo fsdiogo merged commit 173454c into master Feb 6, 2019
@ghost ghost removed the status/in-progress In progress label Feb 6, 2019
@fsdiogo fsdiogo deleted the feat/add-loading-for-file-resp branch February 6, 2019 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants