chore: update add dropdown #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
olizilla
requested changes
Feb 5, 2019
olizilla
reviewed
Feb 6, 2019
License: MIT Signed-off-by: Oli Evans <oli@tableflip.io>
|
I tweaked the AddButton to remove the i18n and lng props as they were being passed through to the dom element. I tweaked the new file button to use v-mid on the svg rather than flex, and wrapped the text in its own span with a |
olizilla
approved these changes
Feb 6, 2019
lidel
reviewed
Feb 6, 2019
| "addByPath": "Add by path", | ||
| "addToIPFS": "Add to IPFS", | ||
| "addFile": "File", | ||
| "addFolder": "Folder", |
| "addToIPFS": "Add to IPFS", | ||
| "addFile": "File", | ||
| "addFolder": "Folder", | ||
| "addByPath": "From IPFS", |
There was a problem hiding this comment.
May be just me, but perhaps more explicit styling of "IPFS" as a path would make it more clear:
From
/ipfs/…
|
A couple of suggestions/observations made on our call today:
|
|
@lidel @terichadbourne what do you think:
|
|
@fsdiogo Yes, that’s much easier for me to understand! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #915 (comment), I've refactored the add dropdown. Heavily inspired by Drive and Dropbox.
create new folderfrom theadd to ipfsdropdown. This way, everything inside that dropdow is to add file/folder/cid to our repo.+ Add. Previously we had+ Add to IPFS, which is not 100% correct. This let me update theAdd by pathwhich was super confusing, toAdd from IPFS, which I think is more clear because it tells you you're adding something that is already on IPFS.Closes #915.