Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add react-virtualized to the files list #957

Merged
merged 19 commits into from
Feb 25, 2019
Merged

feat: add react-virtualized to the files list #957

merged 19 commits into from
Feb 25, 2019

Conversation

fsdiogo
Copy link
Contributor

@fsdiogo fsdiogo commented Feb 12, 2019 •
edited
Loading

  • Using react-virtualized to only render the files in view
  • Loading animation when listing takes more than 1s to load
  • Dir sizes only show if current dir has < 100 files (fix in an incoming PR)

@ghost ghost assigned fsdiogo Feb 12, 2019
@ghost ghost added the status/in-progress In progress label Feb 12, 2019
@olizilla
Copy link
Member

@fsdiogo I'm seeing the firefox rendering issue again on this branch

screenshot 2019-02-13 at 09 00 24

@fsdiogo
Copy link
Contributor Author

fsdiogo commented Feb 13, 2019

Oh noes! With the whole <ContextMenu> refactor I forgot to apply the Firefox fix again.

I'll add that fix to master and then sync this branch.

fsdiogo and others added 7 commits February 13, 2019 11:02
@fsdiogo
Merge branch 'master' into feat/render-large-files-list
1531fa8
@fsdiogo
wip: add empty row
277448d
@fsdiogo
wip: add WindowScroller and fix upperDir issues
9e8a515
@fsdiogo
wip: upperDir logic done
001692f
@fsdiogo
wip: fix checkboxes
2f3ba8a
@fsdiogo
wip: checkbox update
a9a721d
@olizilla
fix: virtualized file list with window scroll
b03e934 
TODO:
- only stat files in view.
- plaeholder for file or dir icon
- turn off stale retry on files redux bundle... its terrible ux to reload a large dir listing every n seconds.
- may have to replace the loading animation with something that doesn't re-render the list
- fix keyboard controls, see: https://bvaughn.github.io/react-virtualized/#/components/ArrowKeyStepper

License: MIT
Signed-off-by: Oli Evans <oli@tableflip.io>
@ghost ghost assigned olizilla Feb 19, 2019
@fsdiogo fsdiogo changed the title [WIP] feat: add react-virtualized to the files list feat: add react-virtualized to the files list Feb 25, 2019
olizilla
olizilla requested changes Feb 25, 2019
View reviewed changes
Copy link
Member

@olizilla olizilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor issue: Renaming items in the list, the item doesnt get the new name unless i scroll them out of view and back again, or navigate away and come back.

src/files/files-list/FilesList.js Outdated Show resolved Hide resolved
@olizilla
Copy link
Member

The "select and it immediately deselect" problem has re-appeared on firefox.

  • Use keyboard nav to highlight an item
  • hit spacebar to select
  • checkbox is checked and then unchecked again
  • expected checkbox remains checked

see: #889

@fsdiogo fsdiogo merged commit de2d68c into master Feb 25, 2019
@ghost ghost removed the status/in-progress In progress label Feb 25, 2019
@fsdiogo fsdiogo deleted the feat/render-large-files-list branch February 25, 2019 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olizilla olizilla olizilla requested changes

@hacdias hacdias Awaiting requested review from hacdias

Assignees

@olizilla olizilla

@fsdiogo fsdiogo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fsdiogo @olizilla