-
Notifications
You must be signed in to change notification settings - Fork 12
fix: fix generated types to missing import #86
Conversation
Thank you for submitting this PR!
Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. |
I think this breaks the transpiled CJS version as it changes the shape of the exported object: // src/index.js
import * as ShardImport from './shard.js'
export const shard = {
...ShardImport
} // dist/cjs/index.js
var shard$1 = require('./shard.js');
const shard = shard$1;
exports.shard = shard; vs // src/index.js
export * as shard from './shard.js' // dist/cjs/index.js
var shard$1 = require('./shard.js');
const shard = shard$1;
exports.PREFIX = shard.PREFIX;
exports.Prefix = shard.Prefix;
exports.README_FN = shard.README_FN;
exports.SHARDING_FN = shard.SHARDING_FN;
exports.ShardBase = shard.ShardBase;
exports.Suffix = shard.Suffix;
exports.parseShardFun = shard.parseShardFun;
exports.readShardFun = shard.readShardFun; If I change export const Errors = ErrorsImport
export const shard = ShardImport I get: export { BaseDatastore } from "./base.js";
export { MemoryDatastore } from "./memory.js";
export { KeyTransformDatastore } from "./keytransform.js";
export { ShardingDatastore } from "./sharding.js";
export { MountDatastore } from "./mount.js";
export { TieredDatastore } from "./tiered.js";
export { NamespaceDatastore } from "./namespace.js";
export const Errors: typeof ErrorsImport;
export const shard: typeof ShardImport;
export type Shard = import("./types").Shard;
export type KeyTransform = import("./types").KeyTransform;
import * as ErrorsImport from "./errors.js";
import * as ShardImport from "./shard.js";
//# sourceMappingURL=index.d.ts.map Can you try overwriting the generated |
1972a1f
to
9570f10
Compare
Thanks @achingbrain for the detail, it works great! |
🎉 This PR is included in version 7.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Motivation
Got this error when using this in lodestar
Description