This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
fix: prevent delete from sending multiple args in callback #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue in node10 where unlink could call the callback as
callback(err, undefined)
. This resulted in test suite failures for ipfs-repo as it was attempting to use async/waterfall.This PR simply enforces the callback only ever returning an error, if one exists.
The following chain would cause the callback being sent to
datastore.has
to undefined.This is related to the following issues, but is not the core cause, it is just causing test suite failures in node v10.
relates to ipfs/js-ipfs#1347
relates to ipfs/js-ipfs-repo#167