This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
fix: swap leveldown/level.js for level #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `level` module bundles `leveldown`, `encoding-down` and `levelup`, as well as subsituting `level.js` for `leveldown` in the browser. This change uses `level` over all those other modules.
vweevers
reviewed
Jun 25, 2019
src/index.js
Outdated
| compression: false // same default as go | ||
| }) | ||
|
|
||
| this.db.put = promisify(this.db.put) |
There was a problem hiding this comment.
Why is this needed? In case a custom db (opts.db) is passed in?
There was a problem hiding this comment.
I was seeing errors like 'get() requires a callback argument' ...and now I'm not. Have removed.
dirkmc
approved these changes
Jun 25, 2019
alanshaw
approved these changes
Jun 25, 2019
rvagg
approved these changes
Jun 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
levelmodule bundlesleveldown,encoding-downandlevelup, as well as substitutinglevel.jsforleveldownin the browser.This change uses
levelover all those other modules.