Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

Update deps #23

Merged
merged 1 commit into from
Nov 29, 2019
Merged

Update deps #23

merged 1 commit into from
Nov 29, 2019

Conversation

achingbrain
Copy link
Member

Also fixes #22 as whatever this module depended on that depended on left-pad no longer depends on left-pad.

@vweevers
Copy link

@achingbrain
Copy link
Member Author

Which caveat do you mean? We're going from 5.x.x to 6.x.x - I didn't see anything specific about that in UPGRADING.md

@vweevers
Copy link

IIRC y'all are using level in the browser too, right? So:

Existing IndexedDB databases created with level-js@4 can be read only if they used binary keys and string or binary values. Other types will come out stringified, and string keys will sort incorrectly. Use the included upgrade() utility to convert stored data to binary (in so far the environment supports it):

@achingbrain
Copy link
Member Author

Aha, thanks for the clarification. This would also have been a problem with the previous dependency on level@5.0.1 though, correct?

@vweevers
Copy link

vweevers commented Oct 29, 2019

This would also have been a problem with the previous dependency on level@5.0.1 though, correct?

No. I think we're mixing up level and level-js.

@achingbrain achingbrain merged commit faf04f4 into master Nov 29, 2019
@achingbrain achingbrain deleted the update-deps branch November 29, 2019 11:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

leftpad warning on 0.39
2 participants