Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

fix: Windows interop #4

Merged
merged 7 commits into from
Nov 6, 2017
Merged

fix: Windows interop #4

merged 7 commits into from
Nov 6, 2017

Conversation

richardschneider
Copy link
Contributor

No description provided.

@ghost ghost assigned richardschneider Nov 4, 2017
@ghost ghost added the status/in-progress In progress label Nov 4, 2017
@richardschneider
Copy link
Contributor Author

@diasdavid needs your Flow magic.

Copy link
Member

@daviddias daviddias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing due to flow. Mind checking @richardschneider ?

@richardschneider
Copy link
Contributor Author

richardschneider commented Nov 5, 2017

@diasdavid I don't think flow is setup correctly. I simply told it ignore to node_modules. You are the one with magic to make projects work with it. Is this really buying you anything?

@daviddias
Copy link
Member

I defer that question to @dignifiedquire, the flow evangelist around here (I do like types though, but definitely haven't made a decision to use flow as a community).

@richardschneider
Copy link
Contributor Author

@dignifiedquire No need for you attention. I rtfm on flow and made the fixes.

@richardschneider
Copy link
Contributor Author

@diasdavid CI is passing. Can you release it now. I need to rebuild ipfs-repo next!

@daviddias daviddias merged commit 5d67042 into master Nov 6, 2017
@daviddias daviddias deleted the windows-interop branch November 6, 2017 06:51
@ghost ghost removed the status/in-progress In progress label Nov 6, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants