Skip to content

fix: really remove node globals #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 27, 2020
Merged

fix: really remove node globals #219

merged 4 commits into from
Apr 27, 2020

Conversation

@hugomrdias
Copy link
Member

@hugomrdias hugomrdias commented Apr 23, 2020

No description provided.

@hugomrdias hugomrdias mentioned this pull request Apr 23, 2020
Closed
56 tasks
@hugomrdias hugomrdias requested a review from dirkmc April 23, 2020 19:29
@hugomrdias hugomrdias marked this pull request as draft April 24, 2020 13:58
@hugomrdias hugomrdias marked this pull request as ready for review April 24, 2020 14:42
dirkmc
dirkmc approved these changes Apr 27, 2020
View reviewed changes
Copy link
Contributor

@dirkmc dirkmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dirkmc dirkmc merged commit 120d1c7 into master Apr 27, 2020
@dirkmc dirkmc deleted the fix/really-remove-node-globals branch April 27, 2020 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dirkmc dirkmc dirkmc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hugomrdias @dirkmc