Bitswap Complete (1.0.0 + 1.1.0) #45
Conversation
daviddias
commented
Oct 20, 2016
•
daviddias
commented
- Needs to support both bitswap 1.1.0 and 1.0.0
- Needs js-multistream to support custom validation functions (mainly semver)
- New Bitswap message.proto (supports both old and new)
- https://github.com/ipfs/go-ipfs/blob/master/exchange/bitswap/message/pb/message.proto
|
|
||
| module.exports = Bitswap | ||
|
|
||
| function noop () {} |
There was a problem hiding this comment.
didn't we agree that we would stop doing style refactorings that are based on personal preferences?
There was a problem hiding this comment.
I might be wrong, but I don't see this as a style preference. Seeing cb = cb || noop is more simpler than cb = cb || (() => {}) everytime I want a noop.
I can revert back though.
As I said at the top of the PR: "Nothing to see here", which was meant to save time from CR, this is far from complete (note that I didn't add the "needs review" label).
| addBlock (block) { | ||
| this.blocks.set(mh.toB58String(block.key), block) | ||
| addBlock (block, hashAlg) { | ||
| const key = block.key(hashAlg) |
There was a problem hiding this comment.
this is going to be async with the new crypto. so might be better to base it on top of that
There was a problem hiding this comment.
It would be incredibly hard to work on top of a PR of PRs and do PR of PRs. One giant at a time, that is why we have git :)
| const mainBlob = new Store(id) | ||
| const blocksBlob = new Store(`${id}/blocks`) | ||
| const mainBlob = new Store(id + Math.random()) | ||
| const blocksBlob = new Store(`${id}/blocks` + Math.random()) |
There was a problem hiding this comment.
This was due to ipfs/js-ipfs#528 (comment)
| @@ -46,7 +46,7 @@ module.exports = (repo) => { | |||
| }) | |||
|
|
|||
| describe('receive message', () => { | |||
| it('simple block message', (done) => { | |||
| it.only('simple block message', (done) => { | |||
There was a problem hiding this comment.
TODO: remove before merge
...someone needs to pay better attention to headlines *cough Just ignore me till you are ready :) |
daviddias
added
status/ready
