-
Notifications
You must be signed in to change notification settings - Fork 299
[WIP] fix: propagate trailer errors correctly #636
Conversation
cc08746
to
bde2489
Compare
bde2489
to
dfee6e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other than needing tests, LGTM.
@richardschneider Windows tests seem to be inconsistent (failing again), mind taking a look? It is not due to this PR but since Appveyor was gracious enough to let this PR do a run, we should take advantage and look at what it says. |
@daviddias, yep working on tests right now. |
It looks like the |
Codecov Report
@@ Coverage Diff @@
## master #636 +/- ##
==========================================
+ Coverage 84.1% 84.25% +0.15%
==========================================
Files 115 115
Lines 1749 1747 -2
==========================================
+ Hits 1471 1472 +1
+ Misses 278 275 -3
Continue to review full report at Codecov.
|
@diasdavid I'm still getting |
fixes - #607
needs tests