Skip to content
This repository was archived by the owner on Sep 28, 2021. It is now read-only.

fix: add node dev deps #81

Merged
merged 1 commit into from
Mar 17, 2021
Merged

fix: add node dev deps #81

merged 1 commit into from
Mar 17, 2021

Conversation

vasco-santos
Copy link
Member

With the new aegir update, followed by merging #79 the build fails due to:

 > node_modules/mime-types/index.js:16:22: error: Could not resolve "path" (set platform to "node" when building for node)
    16 │ var extname = require('path').extname
       ╵                       ~~~~~~

 > node_modules/web-encoding/src/lib.cjs:4:61: error: Could not resolve "util" (set platform to "node" when building for node)
    4 │   typeof TextEncoder !== "undefined" ? TextEncoder : require("util").TextEncoder

This PR adds them as dev deps and adds the build to CI

@vasco-santos vasco-santos force-pushed the fix/add-node-dev-deps branch from 40e21c0 to ced9811 Compare March 17, 2021 08:35
@vasco-santos vasco-santos requested a review from hugomrdias March 17, 2021 08:53
@vasco-santos vasco-santos merged commit 9fcc821 into master Mar 17, 2021
@vasco-santos vasco-santos deleted the fix/add-node-dev-deps branch March 17, 2021 08:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants