This repository has been archived by the owner on Oct 1, 2021. It is now read-only.
fix: replace node buffers with uint8arrays #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGES: - node `Buffer`s have been replaced with `Uint8Array`s
Gozala
approved these changes
Jul 30, 2020
| await store.put(VERSION_KEY, Buffer.from(loadFixture('test/fixtures/test-repo/version'))) | ||
| await store.put(CONFIG_KEY, Buffer.from(loadFixture('test/fixtures/test-repo/config'))) | ||
| await store.put(VERSION_KEY, loadFixture('test/fixtures/test-repo/version')) | ||
| await store.put(CONFIG_KEY, loadFixture('test/fixtures/test-repo/config')) |
There was a problem hiding this comment.
🤷♂️ I'm not sure I get why Buffer.from was used in first place because loadFixture returns buffer as far as I can tell. It's probably a good idea to turns them into Uint8Arrays to ensure that put does in fact works with Uint8Array as opposed to Buffer.
There was a problem hiding this comment.
I'm not sure either TBH.
Converting them to Unint8Arrays to ensure it works seems unnecessary as we're not testing the store implementation here.
64 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
BREAKING CHANGES:
Buffers have been replaced withUint8Arrays