Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

locks #11

Merged
merged 6 commits into from
Dec 11, 2015
Merged

locks #11

merged 6 commits into from
Dec 11, 2015

Conversation

daviddias
Copy link
Member

-> #9

@daviddias daviddias changed the title locks WIP - locks Dec 11, 2015
@daviddias
Copy link
Member Author

Travis, you are drunk, go home. There is no .read on line 57 and you are looking at the wrong commit (03afbce !== 8864197)

daviddias added a commit that referenced this pull request Dec 11, 2015
@daviddias
Merge pull request #11 from ipfs/locks
c03d183 
WIP - locks
@daviddias daviddias merged commit c03d183 into master Dec 11, 2015
@daviddias daviddias deleted the locks branch December 11, 2015 19:44
masylum
masylum reviewed Dec 11, 2015
View reviewed changes
src/index.js

init: function (config, callback) {
self.init = function (config, callback) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and here comes the self 😄

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahah eventually we will run perf analysis everywhere and there will be a cascade of .prototype and named functions, until then, this makes the code so easy to read :D

@daviddias daviddias changed the title WIP - locks locks Dec 14, 2015
@daviddias daviddias mentioned this pull request Dec 14, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daviddias @masylum