Fix error with key generation on Windows #148
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ckenberry's patch
|
Thanks for the PR. This issue is much deeper in the stack and is being addressed by ipfs/js-ipfs#1017. Basically a Key path should NOT be os-specific and always use the forward slash. Hopefully all will be fixed in a few days |
|
Understood! Thanks for the comment. Right now it seems to be working for us and atm we're all windows based. Will definitely keep an eye out for the real fix soon :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix by Balanced Media Technology
The key being generated is used as a file path, and was only supportive of a unix-based pathing system (forward vs backwards slashes)
Changed to use Node Path's path.sep to provide OS specific slashes for pathing.