Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use new datastore-idb #225

Merged
merged 15 commits into from
Apr 20, 2020
Merged

feat: use new datastore-idb #225

merged 15 commits into from
Apr 20, 2020

Conversation

hugomrdias
Copy link
Member

@hugomrdias hugomrdias commented Apr 2, 2020 •
edited
Loading

This PR removes node globals and reduces bundle size. size: 77.09KB -> 45.07KB
Also a new fast and smaller browser datastore is used datastore-idb https://github.com/ipfs/js-datastore-idb

datastore-idb up to 44% faster and 69% smaller

batch idb x 5.26 ops/sec ±4.57% (29 runs sampled)
batch level x 2.92 ops/sec ±3.76% (19 runs sampled)
Fastest is batch idb
    
size 37.32KB to 11.41KB

@hugomrdias hugomrdias changed the title This PR removes node globals and reduces bundle size fix: remove node globals Apr 2, 2020
@hugomrdias hugomrdias mentioned this pull request Apr 2, 2020
Closed
56 tasks
@hugomrdias hugomrdias requested a review from achingbrain April 2, 2020 20:09
@hugomrdias hugomrdias force-pushed the fix/remove-node-globals branch from ada7b45 to 3ca0bf9 Compare April 14, 2020 15:47
@achingbrain
Copy link
Member

Can this be split into two PRs please? One for node globals (a patch) and one for a new datastore (a major)

@hugomrdias
Copy link
Member Author

can't remove node globals with datastore-level

achingbrain
achingbrain reviewed Apr 14, 2020
View reviewed changes
achingbrain
achingbrain reviewed Apr 14, 2020
View reviewed changes
@hugomrdias @achingbrain
fix: change expect to to.equal
6fb4e34 
Co-Authored-By: Alex Potsides <alex@achingbrain.net>
@hugomrdias
chore: change cids to ^0.8.0
35f9ac8
@hugomrdias
Merge branch 'fix/remove-node-globals' of github.com:ipfs/js-ipfs-rep…
938ef00 
…o into fix/remove-node-globals

* 'fix/remove-node-globals' of github.com:ipfs/js-ipfs-repo:
  fix: change expect to `to.equal`
achingbrain
achingbrain approved these changes Apr 14, 2020
View reviewed changes
Copy link
Member

@achingbrain achingbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just needs green CI

@hugomrdias
Copy link
Member Author

LGTM, just needs green CI

yeah trying to fix it... i have no idea whats happening with the linux runs

@hugomrdias hugomrdias requested a review from achingbrain April 15, 2020 10:56
achingbrain
achingbrain reviewed Apr 15, 2020
View reviewed changes
@hugomrdias hugomrdias requested a review from achingbrain April 15, 2020 15:59
@achingbrain achingbrain changed the title fix: remove node globals feat: use new datastore-idb Apr 20, 2020
@achingbrain achingbrain merged commit 99df42b into master Apr 20, 2020
@achingbrain achingbrain deleted the fix/remove-node-globals branch April 20, 2020 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achingbrain achingbrain Awaiting requested review from achingbrain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hugomrdias @achingbrain