Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cids should be a dependency, not a devDependency #118

Closed
rrthomas opened this issue Feb 17, 2021 · 2 comments
Closed

cids should be a dependency, not a devDependency #118

rrthomas opened this issue Feb 17, 2021 · 2 comments
Labels
need/triage Needs initial labeling and prioritization

Comments

@rrthomas
Copy link

rrthomas commented Feb 17, 2021 •
edited
Loading

The module cids is required by src/utils/persist.js.

I found this problem because of hitting an error exactly like this one, which was caused by an old version of cids, which is required by web3, happening to be the version in the top level of my project's node_modules.

Thanks for IPFS!
@rrthomas rrthomas added the need/triage Needs initial labeling and prioritization label Feb 17, 2021
@achingbrain
Copy link
Member

Nice spot, thanks for opening this. It should be fixed in ipfs-unixfs-importer@6.0.0 and above. It'll get rolled into IPFS as part of ipfs/js-ipfs#3550 and shipped in the next release.

@rrthomas
Copy link
Author

Thanks for the quick fix, @achingbrain!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
need/triage Needs initial labeling and prioritization
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rrthomas @achingbrain