feat: adds metadata to unixfs #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds two new fields `mtime` and `mode` in line with the unixfs spec. One possible wart here is that `mtime` is implemented as a JavaScript number which means it can't hold the full value of `int64` so cannot represent dates in the far future. This should be addressed by UnixFSv2 which should hopefully arrive before we top out `Number.MAX_SAFE_INTEGER` - e.g. early June 2255.
alanshaw
approved these changes
Nov 18, 2019
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two new fields
mtimeandmodein line with the unixfs spec.One possible wart here is that
mtimeis implemented as a JavaScript number which means it can't hold the full value ofint64so cannot represent dates in the far future.This should be addressed by UnixFSv2 which should hopefully arrive before we top out
Number.MAX_SAFE_INTEGER- e.g. early June 2255.