-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove node globals #52
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -35,13 +35,13 @@ | |
}, | ||
"homepage": "https://github.com/ipfs/js-ipfs-unixfs#readme", | ||
"devDependencies": { | ||
"aegir": "^21.3.0", | ||
"aegir": "^21.9.0", | ||
"chai": "^4.2.0", | ||
"dirty-chai": "^2.0.1", | ||
"nyc": "^15.0.0" | ||
}, | ||
"dependencies": { | ||
"err-code": "^2.0.0", | ||
"protons": "^1.1.0" | ||
"protons": "^1.0.2" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why the downgrade? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. the latest release is 1.0.2 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No it's not - I think the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yeah but the latest code is released under 1.0.2 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No idea what's happened there, someone must have published and then forgotten to push the tags etc. I've published a new version from the head of master as 1.2.0 |
||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is
strategies[strategy]
not needed?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i dunno what was the deal with
strategies[strategy]
it's an array of string being merged with a object of objects so i removed it and everything still worked