This repository was archived by the owner on Feb 12, 2024. It is now read-only.
Add pre-push lint? #1705
Labels
exp/novice
Someone with a little familiarity can pick up
help wanted
Seeking public contribution on this issue
P4
Very low priority
status/ready
Ready to be worked
Comments
alanshaw
added
exp/novice
Prabhakar-Poudel
pushed a commit
to Prabhakar-Poudel/js-ipfs
that referenced
this issue
May 22, 2019
closes: ipfs#1705 License: MIT Signed-off-by: Prabhakar Poudel yuvrajzohan@gmail.com
Prabhakar-Poudel
pushed a commit
to Prabhakar-Poudel/js-ipfs
that referenced
this issue
May 22, 2019
closes: ipfs#1705 License: MIT Signed-off-by: Prabhakar Poudel yuvrajzohan@gmail.com
Prabhakar-Poudel
pushed a commit
to Prabhakar-Poudel/js-ipfs
that referenced
this issue
May 25, 2019
closes: ipfs#1705 License: MIT Signed-off-by: Prabhakar Poudel yuvrajzohan@gmail.com
Prabhakar-Poudel
pushed a commit
to Prabhakar-Poudel/js-ipfs
that referenced
this issue
May 30, 2019
closes: ipfs#1705 License: MIT Signed-off-by: Prabhakar Poudel <yuvrajzohan@gmail.com>
alanshaw
pushed a commit
that referenced
this issue
May 31, 2019
closes: #1705 License: MIT Signed-off-by: Prabhakar Poudel <yuvrajzohan@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Currently we don't do any pre-push behaviors in js-ipfs. Testing makes sense not to do because it takes way too long for everyone to have to run that locally. Linting is relatively quick (around 7 seconds for me locally).
While 7 seconds is annoying on a push, having this go to ci and doing an npm install on all agents before it lints is expensive if linting is going to fail, and is worth the time imo.
I think all warnings should be fixed before doing this.
The text was updated successfully, but these errors were encountered: