Only log addresses that are actually being listened on

[dignifiedquire]

In https://github.com/ipfs/js-ipfs/blob/master/src/core/ipfs/libp2p.js#L16-L18 it prints all addresses that are passed in but sometimes those listens fail or do not happen at all (e.g. in the browser).

[daviddias]

👍 , note however, that adding websockets, tcp or any multiaddrs to the browser PeerInfo is not recommended (at all), because those multiaddrs will be propagate and no other peer will be able to dial to the browser on those multiaddrs.

[daviddias]

@dignifiedquire wanna handle this one?

[dignifiedquire]

@diasdavid sure

[dignifiedquire]

So this is more tricky than I thought, I would suggest changing libp2p-swarm in a way that it drops all multiaddrs in swarm.peerInfo.multiaddrs that are not listened on and as such the log statement in js-ipfs doesn't need to be changed. Any better ideas @diasdavid ?

[daviddias]

We can't drop the multiaddrs that we weren't able to listen into, since these multiaddrs might be valid only under certain networks, so the fact that I'm not listening in an addr now, might just mean that on the wifi network that I'm right now, that multiaddr doesn't work, but I might change networks (without closing my daemon) and then I want to listen on that multiaddr.

We need to upgrade peer-info to enumerate the active addresses. This will also be useful for knowing which multiaddr we used to connect to a certain peer.

[victorb]

would it make sense for the daemon to listen for network changes and try to
start listen to interfaces after start and print if it manages to connect
to a new interface?

On Mon, Sep 26, 2016 at 12:33 PM, David Dias notifications@github.com
wrote:

We can't drop the multiaddrs that we weren't able to listen into, since
these multiaddrs might be valid only under certain networks, so the fact
that I'm not listening in an addr now, might just mean that on the wifi
network that I'm right now, that multiaddr doesn't work, but I might change
networks (without closing my daemon) and then I want to listen on that
multiaddr.

We need to upgrade peer-info to enumerate the active addresses. This will
also be useful for knowing which multiaddr we used to connect to a certain
peer.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#213 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAcD9Ficn7Bpl8KXVk9qrG8RtoGZzE9Hks5qt5-MgaJpZM4IcUp8
.