Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Use mafmt module to only append peer ids to certain multiaddrs #2727

Closed
achingbrain opened this issue Jan 23, 2020 · 0 comments · Fixed by #2833
Closed

Use mafmt module to only append peer ids to certain multiaddrs #2727

achingbrain opened this issue Jan 23, 2020 · 0 comments · Fixed by #2833
Labels
exp/novice Someone with a little familiarity can pick up kind/bug A bug in existing code (including security flaws) P3 Low: Not priority right now status/ready Ready to be worked

Comments

@achingbrain
Copy link
Member

As part of startup we append our peer id to every multiaddr that contains a peer id.

This should only happen to circuit addresses. We should use the mafmt module to match on those.
@alanshaw alanshaw added kind/bug A bug in existing code (including security flaws) exp/novice Someone with a little familiarity can pick up P3 Low: Not priority right now status/ready Ready to be worked labels Feb 4, 2020
@achingbrain achingbrain mentioned this issue Mar 9, 2020
Merged
@achingbrain achingbrain linked a pull request Mar 9, 2020 that will close this issue
fix: multiaddr validation to add peer id for listening #2833
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
exp/novice Someone with a little familiarity can pick up kind/bug A bug in existing code (including security flaws) P3 Low: Not priority right now status/ready Ready to be worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: multiaddr validation to add peer id for listening ipfs/js-ipfs
2 participants
@alanshaw @achingbrain