This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
fix: multiaddr validation to add peer id for listening #2833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
force-pushed
the
fix/multiaddr-validation-to-add-peer-id-for-listening
branch
from
e3a9919
to
cccb0b2
Compare
|
Do you think this would be better done by only appending the peer id to certain types of multiaddrs, a la #2727 ? |
|
I haven't considered that since I did not know about the issue, but this is a good question! This also needs to be considered for FYI, we currently consider multiaddr without |
achingbrain
reviewed
Mar 27, 2020
achingbrain
approved these changes
Mar 27, 2020
achingbrain
deleted the
fix/multiaddr-validation-to-add-peer-id-for-listening
branch
mistakia
pushed a commit
to mistakia/js-ipfs
that referenced
this pull request
Apr 3, 2020
* fix: multiaddr validation to add peer id for listening * chore: update packages/ipfs/src/core/components/start.js Co-authored-by: Alex Potsides <alex@achingbrain.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we add the own peer id to a multiaddr, we should verify if it already has it, or if it is an address of
circuit-relay/stardust. Otherwise, we might end up with multiaddrs like:/ip4/127.0.0.1/tcp/5892/ws/p2p/PEER_ID/p2p/PEER_ID