Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Make entry.type consistent arcoss various APIs #3229

Closed
Gozala opened this issue Aug 15, 2020 · 3 comments
Closed

Make entry.type consistent arcoss various APIs #3229

Gozala opened this issue Aug 15, 2020 · 3 comments
Assignees
Labels
kind/enhancement A net-new feature or improvement to an existing feature status/ready Ready to be worked

Comments

@Gozala
Copy link
Contributor

Gozala commented Aug 15, 2020

Following APIs seem to return different thing for entry.type:

This can be very confusing when working with all these APIs as just like ipfs-webui does.

I would like to propose normalizing to a consistent variants for type.

@Gozala Gozala added the need/triage Needs initial labeling and prioritization label Aug 15, 2020
@achingbrain
Copy link
Member

achingbrain commented Aug 15, 2020

Yes please, this has been on the list for ages. All type fields should be one of the UnixFS data types, my preference is for lower case, kebab-case strings, though using the enum value from the UnixFS spec would also be acceptable and strings could be a UI concern, but beware that go-IPFS uses different numbers depending on context.

See also:

@achingbrain achingbrain added kind/enhancement A net-new feature or improvement to an existing feature status/ready Ready to be worked and removed need/triage Needs initial labeling and prioritization labels Aug 15, 2020
@Gozala Gozala self-assigned this Aug 15, 2020
@achingbrain
Copy link
Member

Also see ipfs/kubo#7553 for another stat command that's being added.

@achingbrain
Copy link
Member

Closing as this issue is very stale.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/enhancement A net-new feature or improvement to an existing feature status/ready Ready to be worked
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants