This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
mfs file type should return same type #2948
Comments
The spec docs say the Would you like to create a PR for this that changes it to use strings everywhere? The HTTP API should remain unchanged but we can translate the types in core & the client. You'll most likely have to change the interface tests too. Please make sure HAMT sharded directories are handled correctly. |
Fixed in #3352 |
SgtPooki
referenced
this issue
in ipfs/js-kubo-rpc-client
Aug 18, 2022
Supersedes #3345 #2939 Fixes #3330 #2948 BREAKING CHANGE: types returned by `ipfs.files.ls` are now strings, in line with the docs but different to previous behaviour Co-authored-by: Geoffrey Cohler <g.cohler@computer.org>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
from
stat
isstring
from
ls
isnumber
this will easy make bug happen when we not check real return value
The text was updated successfully, but these errors were encountered: