IPFS.files.ls returns integer not 'directory'/'file' in type attribute

[gcohler]

From what I can tell, the documentation and the implementation differ.

Documentation here: https://github.com/ipfs/js-ipfs/blob/master/docs/core-api/FILES.md#ipfsfileslspath-options.

What I received was a 1 for directory.

[welcome]

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review.
In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment.
Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

• "Priority" labels will show how urgent this is for the team.
• "Status" labels will show if this is ready to be worked on, blocked, or in progress.
• "Need" labels will indicate if additional input or analysis is required.

Finally, remember to use https://discuss.ipfs.io if you just need general support.

[achingbrain]

This should return a string in line with the docs - would you like to open a PR that fixes it?

[gcohler]

I don't know the code-base well enough. But I would suggest the following two changes (from my investigation).

1. In the MFS_FILE_TYPES definition, there are two entries with the same number assigned. That appears to be a problem.

My proposal: In https://github.com/ipfs/js-ipfs/blob/master/packages/ipfs-core/src/utils.js. Change line 21 to:

  'hamt-sharded-directory': 2

2. In the toOutput function it doesn't translate into a string.

My proposal: In https://github.com/ipfs/js-ipfs/blob/master/packages/ipfs-core/src/components/files/ls.js: Change line 18 to:

type = Object.entries(MFS_FILE_TYPES).find(x => x[1] == fsEntry.unixfs.type)[0];

[gcohler]

@achingbrain I submitted a PR.