ipfs resolve fails when dnslink points to another dnslink

[olizilla]

ipfs resolve isn't happy about dnslinks that point to other domains.

$ dig +short txt _dnslink.ipfs.io
"dnslink=/ipns/website.ipfs.io"

$ iim use js
✔ selected js-ipfs version 0.55.1

$ ipfs resolve /ipns/ipfs.io
invalid character '.' in 'website.ipfs.io'

[olizilla]

Here ipfs resolve short-cuts where it is given an name and tries to return the response from ipfs dns rather than fully resolving

js-ipfs/packages/ipfs-core/src/components/name/resolve.js

Lines 67 to 71 in 00fd709

	// lets check if we have a domain ex. /ipns/ipfs.io and resolve with dns
	if (isDomain(hash)) {
	yield appendRemainder(await dns(hash, options), remainder)
	return
	}

[lidel]

Ouch, ipfs resolve /ipns/ipfs.io failing is pretty bad, that is an example for core feature referred from docs/forums/SO etc :( – for this reason I'm marking this as P0.
@olizilla will you have time to PR fix? If not we should add this ahead of the tribute que for @hugomrdias this week.

[olizilla]

I can PR a fix for this

[olizilla]

Weird, we have a core interface test for exactly this address

js-ipfs/packages/interface-ipfs-core/src/miscellaneous/resolve.js

Lines 78 to 84 in 00fd709

	// Test resolve turns /ipns/domain.com into /ipfs/QmHash
	it('should resolve an IPNS DNS link', async function () {
	this.retries(3)
	const resolved = await ipfs.resolve('/ipns/ipfs.io')
	expect(isIpfs.ipfsPath(resolved)).to.be.true()
	})

[olizilla]

something more mysterious is happening here... the test passes, and the dns command does indeed handle recursive look ups by default

❯ npx aegir test -f test/interface-core.js -t node 
Test Node.js


  interface-ipfs-core tests
    .resolve
resolved /ipfs/bafybeidcwrcmqbzm557vyomf2evvo4zez2uc5qfbajvbhilm62vvvfmmui
      ✓ should resolve an IPNS DNS link (94ms)

js-ipfs/packages/ipfs-core/src/runtime/dns-nodejs.js

Lines 33 to 68 in 00fd709

	async function recursiveResolveDnslink (domain, depth) {
	if (depth === 0) {
	throw errcode(new Error('recursion limit exceeded'), 'ERR_DNSLINK_RECURSION_LIMIT')
	}
	let dnslinkRecord
	try {
	dnslinkRecord = await resolveDnslink(domain)
	} catch (err) {
	// If the code is not ENOTFOUND or ERR_DNSLINK_NOT_FOUND or ENODATA then throw the error
	if (err.code !== 'ENOTFOUND' && err.code !== 'ERR_DNSLINK_NOT_FOUND' && err.code !== 'ENODATA') {
	throw err
	}
	if (domain.startsWith('_dnslink.')) {
	// The supplied domain contains a _dnslink component
	// Check the non-_dnslink domain
	dnslinkRecord = await resolveDnslink(domain.replace('_dnslink.', ''))
	} else {
	// Check the _dnslink subdomain
	const _dnslinkDomain = `_dnslink.${domain}`
	// If this throws then we propagate the error
	dnslinkRecord = await resolveDnslink(_dnslinkDomain)
	}
	}
	const result = dnslinkRecord.replace('dnslink=', '')
	const domainOrCID = result.split('/')[2]
	const isIPFSCID = isIPFS.cid(domainOrCID)
	if (isIPFSCID || !depth) {
	return result
	}
	return recursiveResolveDnslink(domainOrCID, depth - 1)

[olizilla]

the ipfs resolve /ipns/ipfs.io command fails, yet the ipfs dns ipfs.io command succeeds...

~/Code/ipfs/js-ipfs/packages/ipfs on master •
❯ /Users/oli/.iim/dists/js-ipfs@0.55.1/ipfs resolve /ipns/ipfs.io                                                         16:32:30
invalid character '.' in 'website.ipfs.io'

~/Code/ipfs/js-ipfs/packages/ipfs on master •
❯ /Users/oli/.iim/dists/js-ipfs@0.55.1/ipfs dns ipfs.io                                                                   16:32:37
/ipfs/bafybeidcwrcmqbzm557vyomf2evvo4zez2uc5qfbajvbhilm62vvvfmmui

[olizilla]

the ipfs-cli does nothing but hand off to the ipfs instance which i assume is a ipfs-core instance

js-ipfs/packages/ipfs-cli/src/commands/resolve.js

Lines 39 to 42 in 00fd709

	async handler ({ ctx: { print, ipfs }, name, recursive, cidBase, timeout }) {
	const res = await ipfs.resolve(name, { recursive, cidBase, timeout })
	print(stripControlCharacters(res))
	}

[olizilla]

ohhhh, the cli command is not recursive by default!

js-ipfs/packages/ipfs-cli/src/commands/resolve.js

Lines 10 to 19 in 00fd709

	command: 'resolve <name>',
	description: 'Resolve the value of names to IPFS',
	builder: {
	recursive: {
	alias: 'r',
	type: 'boolean',
	default: false
	},

it probably should be.

[olizilla]

The error message where recursive is false but a dnslink points to another dnslink needs improving here

[lidel]

Hm.. you are right. ipfs resolve in go-ipfs was flipped to recursive by default some time ago (~2019?), js-ipfs should do the same. Ref. ipfs/kubo#6087

[lidel]

@olizilla is this still on your plate, or should we unassign so this can be picked up by JS tribute as part of https://github.com/orgs/ipfs/projects/13#card-61290478 ?

This is ready to be picked up by a JS triage tribute.

[lidel]

@yusefnapora (note from JS triage) you may want to pick up this first, before anything else (P0)

[lidel]

Note from triage:

• need CI/tests fix
• can be picked up by tribute or wait until @yusefnapora is back in rotation