Skip to content
This repository was archived by the owner on Feb 12, 2024. It is now read-only.

CLI should accept content from stdin #474

Closed
victorb opened this issue Sep 10, 2016 · 2 comments
Closed

CLI should accept content from stdin #474

victorb opened this issue Sep 10, 2016 · 2 comments
Labels
exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws)

Comments

@victorb
Copy link
Member

victorb commented Sep 10, 2016

The js-ipfs should, like the go-ipfs cli, accept input from stdin and add it correctly.

go-ipfs

$ echo "hello" | IPFS_PATH=~/.ipfs-go ipfs add
added QmZULkCELmmk5XNfCgTnCyFgAVxBRBXyDHGGMVoLFLiXEN QmZULkCELmmk5XNfCgTnCyFgAVxBRBXyDHGGMVoLFLiXEN

current js-ipfs

$ echo "hello" | IPFS_PATH=~/.ipfs-js node src/cli/bin.js files add
src/cli/bin.js files add <file>

Options:
  --help           Show help                                           [boolean]
  --recursive, -r                                     [boolean] [default: false]

Not enough non-option arguments: got 0, need at least 1
@victorb victorb added the kind/bug A bug in existing code (including security flaws) label Sep 10, 2016
@daviddias daviddias added status/ready Ready to be worked and removed js-ipfs-backlog labels Dec 5, 2016
@daviddias daviddias added exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue labels Dec 18, 2016
@daviddias
Copy link
Member

Hey @victorbjelkholm mind adding a test case for this showing the failure?

@daviddias daviddias added status/deferred Conscious decision to pause or backlog and removed status/ready Ready to be worked labels Jan 29, 2017
gpestana added a commit to gpestana/js-ipfs that referenced this issue Mar 11, 2017
Adds support for unix-like piping in js-ipfs, like in go-ipfs cli.

e.g. `echo "hello" | IPFS_PATH=~/.ipfs-go ipfs add` is handled as expected
@daviddias
Copy link
Member

@gpestana has proposed a fix here: #785

Let's follow up there.

@daviddias daviddias removed the status/deferred Conscious decision to pause or backlog label Jul 7, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws)
Projects
None yet
Development

No branches or pull requests

2 participants