-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Pick random ports on tests #90
Comments
go-ipfs doesn't use port 0 for the Gateway, which is where that is failing.
It is strange however, because I changed the config to launch the http-api on port 9090 to avoid those kind of collisions, but it seems that you had something else running on port 9090? |
It does for tests (https://github.com/ipfs/go-ipfs/blob/master/test/sharness/lib/test-lib.sh#L149), and we should too. I run other software on 8080, so I run the gateway on 9090, as may many other users -- 8080 is pretty popular and 9090 is the next most "logical" choice. ;) |
Got it, could you submit a PR for that? |
This isn't on my short term list, so let's open it up as |
Took a shot at it, was actually playing with this last night. |
thank you :) |
We ought to gracefully use port zero (like go-ipfs).
The text was updated successfully, but these errors were encountered: